Check collection equality using isEqual: #3223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow separate references to the same collection
pasin
reviewed
Feb 9, 2024
| @@ -525,7 +525,8 @@ - (BOOL) isEqual: (id)object { | |||
|
|
|||
| if (!(other && [self.name isEqual: other.name] && | |||
| [self.scope.name isEqual: other.scope.name] && | |||
| [self.database.path isEqual: other.database.path])) { | |||
| // don't use isEqual: here! The database must be the exact same instance. | |||
| self.database == other.database)) { | |||
There was a problem hiding this comment.
Have you seen a problem when comparing the database paths?
There was a problem hiding this comment.
Yes, with just the first change from != to ![ isEqual:] it broke these tests. The equality check needs to do the check for separate database instances, which then make the collections not equal.
|
Thanks a lot for creating this PR. I have talked to @bmeike and @borrrden today and we have learnt that each platform has implemented different validation logic when saving the documents and in database / collection equality check. We will have tickets to sync the implementation on each platform. So let me take care this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CBLCollection isEqual:for collection equality checks in order to allow separate references to the same collection. This aligns with the behavior in the Java and C SDKs, which allow this.Also check
CBLCollectiondatabase instances are equal for equality check, similar to Java SDK.