Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBL-6070: Implement Database Full-Sync Option #3318

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

velicuvlad
Copy link
Contributor

  • cherry picked 5c10248 from release/3.1 branch. A couple of small, easy-to-resolve conflicts - nothing important
  • Implemented FullSync DatabaseConfiguration property.
  • Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
  • Update to LiteCore 3.2.0-223

- Implemented FullSync DatabaseConfiguration property.
- Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
@velicuvlad velicuvlad requested a review from pasin August 2, 2024 22:46
@velicuvlad
Copy link
Contributor Author

the build failure is due to one of the tests... still investigating if is just the test or not. The PR has nothing to do with the failure itself, I dont know why it hasn't failed at the time the test was introduced and also why it just doesn't like it for macos - everything is fine on local.

@velicuvlad velicuvlad requested a review from bmeike August 2, 2024 22:57
@pasin
Copy link
Contributor

pasin commented Aug 3, 2024

It's build issue in test. Not sure why it's happening now. It can be fixed by this:

[self expectError: CBLErrorDomain code: CBLErrorNotOpen in: ^BOOL(NSError** err) {
        return [col indexWithName: @"index1" error: err] != nil;
}];

Swift/DatabaseConfiguration.swift Outdated Show resolved Hide resolved
Swift/DatabaseConfiguration.swift Outdated Show resolved Hide resolved
@velicuvlad velicuvlad requested a review from pasin August 5, 2024 13:07
@velicuvlad velicuvlad merged commit 554a301 into release/3.2 Aug 5, 2024
8 checks passed
@velicuvlad velicuvlad deleted the CBL-6070 branch August 5, 2024 14:46
velicuvlad added a commit that referenced this pull request Nov 11, 2024
* CBL-5524 : Add all keys to the Privacy Manifest file (#3258)
* CBL-5541 : Update vector search test per changes in v1.8 (#3260)
* CBL-5365: Remove CBLErrors.h from Swift Public API (#3271)
* CBL-5508: Update Min macOS Support Version to 12.0 (#3272)
* CBL-5693 : Fix missing exported symbols (#3281)
* CBL-5222: MutableDocument should be usable before creating a database instance (#3278)
* CBL-5613: Swift API docs for Scope using Obj-c reference (#3284)
* CBL-5710: Add note that the replicator cannot be started in the inBatch() function (#3286)
* CBL-5514: Swift MutableDocument's collection is not set when a new document is saved (#3287)
* CBL-5660 : Fix a released query context may be used in observer callback (#3285)
* CBL-5668: Get Code Coverage at least 80% (#3289)
* CBL-3385: Allow null expression parameter for Function.count(expression) (#3290)
* CBL-5750  + CBL-5757  Lazy Index - ObjC (#3291)
* CBL-5811 : Support Vector Dimension to 4096 and Vector in Base64 String (#3294)
* CBL-5803 : Implement Lazy Vector Index and Test for Swift (#3295)
* CBL-5567 : Implement log replicator heiroglyphics (#3296)
* CBL-5859 : Allow explicitly enable vector search (#3297)
* CBL-5886: Add missing numProbes and correct min/maxTrainingSize default value (#3298)
* CBL-5932: Update default constants and public symbols (#3299)
* CBL-5928 : CBLErrors.h is not included in the umbrella header (#3301)
* CBL-5927 : Fix Duplicate CBLQueryIndex Interface Definition (#3300)
* CBL-5893: Throw exception for everything if finish() was successfully called beforehand (#3302)
* CBL-5956: Update DistanceMetric (#3303)
* CBL-5690 : Update Distance Metric Enum and VS SQL in Tests (#3304)
* CBL-5990 : Fix _kCBLDefaultLogFileUsePlaintext symbol (#3305)
* CBL-6070: Implement Database Full-Sync Option (#3318)
* CBL-6144: Add testConcurrentCreateAndQuery to verify query's lock (#3320)
* CBL-6191 : Fix null URL for proxy CONNECT request (#3324)
* CBL-5180: Implement Array Index API (#3327)
* CBL-5181: Array Index API tests and adjustments (#3330)
* CBL-5899
* CBL-6307: Database MMap Configuration API and tests (#3333)
* CBL-6349: Implement Document's getRevisionHistory() for E2E Test Server (#3335)
* LiteCore 3.2.1-19
* Export symbol for mmap constant (#3341)
* ArrayIndexConfiguration explicit expressions arg on set (#3342)

---------

Co-authored-by: Pasin Suriyentrakorn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants