Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup MemcachedIF to only export what is really visible by clients #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/net/spy/memcached/MemcachedClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,10 @@ public Transcoder<Object> getTranscoder() {
return transcoder;
}

@Override
public CountDownLatch broadcastOp(final BroadcastOpFactory of) {
return broadcastOp(of, mconn.getLocator().getAll(), true);
}

@Override
public CountDownLatch broadcastOp(final BroadcastOpFactory of,
Collection<MemcachedNode> nodes) {
return broadcastOp(of, nodes, true);
Expand Down
8 changes: 1 addition & 7 deletions src/main/java/net/spy/memcached/MemcachedClientIF.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,13 @@
package net.spy.memcached;

import net.spy.memcached.internal.BulkFuture;
import net.spy.memcached.internal.OperationFuture;
import net.spy.memcached.transcoders.Transcoder;

import java.net.SocketAddress;
import java.util.Collection;
import java.util.Iterator;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;

Expand Down Expand Up @@ -77,7 +75,7 @@ <T> Future<CASResponse> asyncCAS(String key, long casId, T value,

Future<CASResponse> asyncCAS(String key, long casId, int exp, Object value);

<T> OperationFuture<CASResponse> asyncCAS(String key, long casId, int exp,
<T> Future<CASResponse> asyncCAS(String key, long casId, int exp,
T value, Transcoder<T> tc);

<T> CASResponse cas(String key, long casId, int exp, T value,
Expand Down Expand Up @@ -230,10 +228,6 @@ <T> Future<Boolean> touch(final String key, final int exp,

boolean removeObserver(ConnectionObserver obs);

CountDownLatch broadcastOp(final BroadcastOpFactory of);
CountDownLatch broadcastOp(final BroadcastOpFactory of,
Collection<MemcachedNode> nodes);

/**
* Get the set of SASL mechanisms supported by the servers.
*
Expand Down