Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-4240 Backport docs improvements to 3.1 branch #7114

Merged
merged 4 commits into from
Sep 12, 2024
Merged

CBG-4240 Backport docs improvements to 3.1 branch #7114

merged 4 commits into from
Sep 12, 2024

Conversation

adamcfraser
Copy link
Collaborator

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Redocly previews

@torcolvin
Copy link
Collaborator

I forgot one more file to backport - .yamllint.yml and it will fix the yamllint errors.

torcolvin
torcolvin previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM content wise, I think all the 3.2 is present and I don't see any 3.2 specific features.

Adding .yamllint.yml will result in the tests passing, and I'll re-approve.

@adamcfraser adamcfraser assigned torcolvin and unassigned adamcfraser Sep 11, 2024
@torcolvin torcolvin merged commit 4c4fca0 into release/3.1.12 Sep 12, 2024
27 checks passed
@torcolvin torcolvin deleted the CBG-4240 branch September 12, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

Assignees

@torcolvin torcolvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamcfraser @torcolvin