Support configuration of api endpoint for Capella organization #498
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,6 +230,7 @@ pub fn update_config_file(guard: &mut MutexGuard<State>, span: Span) -> Result<( | |||
| c.access_key(), | |||
| Some(c.timeout()), | |||
| c.default_project(), | |||
| None, | |||
There was a problem hiding this comment.
Why is this None?
Presumably we would want to save the api_endpoint to the config file?
There was a problem hiding this comment.
I don't think that we do. Since either the endpoint will be the default, so adding the default endpoint to the file will just cause confusion. Or it will not be the default, in which case it will already be in the config file.
There was a problem hiding this comment.
Ah, I see. Since it's only configurable through the config file, it doesn't make sense to update the config file.
Peter-Searby
approved these changes
Sep 26, 2024
| @@ -230,6 +230,7 @@ pub fn update_config_file(guard: &mut MutexGuard<State>, span: Span) -> Result<( | |||
| c.access_key(), | |||
| Some(c.timeout()), | |||
| c.default_project(), | |||
| None, | |||
There was a problem hiding this comment.
Ah, I see. Since it's only configurable through the config file, it doesn't make sense to update the config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #487