Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set a user agent when downloading CLI #14

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

beanow-at-crabnebula
Copy link
Member

@beanow-at-crabnebula beanow-at-crabnebula commented Oct 16, 2024

The user agent will look something like: cloud-release/v0 (macOS; ARM64)
Where the v0 depends on how the caller referred to the action.

For example, when pinning to a sha hash that would be used instead.
cloud-release/6e3b1c716307d6f1759db4b3dd976aeda0e67b7b (macOS; ARM64)

In our test workflow, we're using a path (./) to refer to the action, so the action_ref is empty and we remove the version suffix like cloud-release (macOS; ARM64).

@beanow-at-crabnebula beanow-at-crabnebula requested a review from a team as a code owner October 16, 2024 16:36
Copy link

Package Changes Through 70f1904

There are 1 changes which include action with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
action 0.2.5 0.2.6

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link

@adam-crabnebula adam-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in QA

@lucasfernog-crabnebula lucasfernog-crabnebula merged commit 0f561fd into main Oct 16, 2024
4 checks passed
@lucasfernog-crabnebula lucasfernog-crabnebula deleted the beanow/curl-user-agent branch October 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants