-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cms 660 show read-only settings when allowAdminChanges
is disabled
#16265
base: 5.6
Are you sure you want to change the base?
Feature/cms 660 show read-only settings when allowAdminChanges
is disabled
#16265
Conversation
…ead-only-settings-when-allowadminchanges-false
Love this! It might be worth adding a "Learn More" button to a KB article explaining why settings can't/shouldn't be changed in production. Newer Craft developers or over-confident clients might read the current disclaimer as instructions to simply turn on "allowAdminChanges" and potentially get themselves in a mess. |
…allowadminchanges-false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@i-just awesome! I pinged you on the Notion page for this feature as I had some follow-up questions.
…allowadminchanges-false
thanks @gcamacho079! I actioned all your comments. Extra info on the Notion page. LMK if anything doesn't make sense. |
…allowadminchanges-false [ci skip]
Thanks for knocking out those changes, @i-just! A couple more things I noticed that should also get the
|
…allowadminchanges-false [ci skip]
Description
Shows read-only settings when
allowAdminChanges
is disabled..revision-notice
to a generic.content-notice
class so that the styles can be reused for other purposes tooallowAdminChanges
is disabled; to do so, they need to ensure none of the settings are editable in such case and implementpublic function canViewReadOnlySettings(): bool;
to return truesrc/events/RegisterCpSettingsEvent
has a new public property$readOnlyModeReady
, which is set to false by default; if the settings changes manipulated via the event are ready to be displayed in a non-editable way, set it totrue
to have them show when admin changes are not allowed.Related issues
cms-660