Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write examples for MakeTimestamp, Closes #14 #17

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

Shresth72
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may expect to add the docs on struct definition.

Did you preview the result locally? I remember that docs on trait method impl don't render well.

You should be able to preview locally with:

RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features --open

@Shresth72
Copy link
Contributor Author

Shresth72 commented Sep 28, 2024

The examples for the trait method impls are rendered above the trait definitions. Would this be an issue?

Description of image

src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough. Merging.

Thanks for your contribution again! And you may request review the next time when you make progress on PR. Push commit and resolve comment won't send a notification though.

@tisonkun tisonkun merged commit 71f9158 into cratesland:main Sep 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants