Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark FallbackTimezoneOption as non_exhaustive #21

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Oct 11, 2024

Although this is less likely to be extended, I'd try to mark it as non_exhaustive.

Typically, people only pass a certain variant to construct a ParseOptions. This only affect when people try to match against variants and then they should handle the _ cases always.

This is related to #16 #18 #19.

@tisonkun tisonkun merged commit cbd6454 into main Oct 11, 2024
5 checks passed
@tisonkun tisonkun deleted the tisonkun-patch-1 branch October 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant