fix: set correct minimum memory values in package.json #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values that are within the package.json are the ones that are used by podman desktop to generate the range of the sliders. Because the max value is in bytes, we also have to use bytes for the minimum.
However CRC expects bits values. So the minimum memory value accepted by CRC for microshift is 4096 MiB converted to bytes 4294967296.
Same calculation has been made for the rest.
This is somehow part of #243 bc with the current values you could set an invalid memory amount. The minimum was 4000000000 bytes that converted to Mib are 3814, which is less than the minimum accepted 4096