Extend the E2E tests to be run on windows #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
2 times, most recently
from
c8552f9 to
4bde536
Compare
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
from
a9eb7fb to
10c3944
Compare
odockal
requested changes
Dec 16, 2024
.github/workflows/pr-check.yaml
Outdated
| - name: Build Podman Desktop for E2E tests | ||
| working-directory: ./podman-desktop | ||
| run: pnpm test:e2e:build | ||
|
|
||
| - name: Adjust/Downgrade local podman desktop version Windows |
There was a problem hiding this comment.
That's what you suggested me I should use to fix the encoding issues I had on the package.json from windows
There was a problem hiding this comment.
It was that you use the command, how it uses jq tool, not that it should downgrade the podman-desktop, or in this case, you are downgrading crc-extension.
There was a problem hiding this comment.
I've removed it, I thought it was solving an issue but it is still working without it
| working-directory: ./podman-desktop | ||
| run: pnpm install | ||
|
|
||
| - name: Install SSO extension dependencies |
There was a problem hiding this comment.
do we need to build sso ourselves? Isn't is possible to just docker pull sso and then create container and export, etc. ?
There was a problem hiding this comment.
I tried earlier that approach, but it had the same issue as building the crc extension that way (complaints that the image is built for linux). I think it's related to the default running containers being windows (not 100% sure), but after several unsuccessful tries to toggle that setting, I figured that building the extension locally like the other one would be just more straightforward.
There was a problem hiding this comment.
the complaining is may related to how you unpack the extension to set them on an spericif path? ....may if you add the feature on the testing framework to just pass the extension image url and directly install trought the UI?
Official releases for extensions are build only once and used across all platforms
There was a problem hiding this comment.
that is too late. when we open PD with locally prepared crc-extension it must have the dependency present (sso-extension) already otherwise the state of extension will be failed.
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
2 times, most recently
from
d3dc56a to
b15e700
Compare
odockal
reviewed
Dec 19, 2024
test(e2e): added windows to pr check test(e2e): fixed ubuntu error test(e2e): fixed windows error test(e2e): fixed windows error - part 2 test(e2e): fixed windows error - part 3 test(e2e): triggering pr-check test(e2e): ditch jq in windows test(e2e): testing why podman is not found Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): install podman in the tests workflow for windows Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): use docker to build extension image Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): swap docker's execution mode to linux Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): revert previous commit Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): new version of build step Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): building locally the extension Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): fix relative path Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): build extension once before test matrix Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): revert - build extension once before test matrix This reverts commit de5650b. test(e2e): swap pnpm to yarn Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): add cache management + frozen lockfile Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): remove frozen lockfile, add previous steps to run only on windows Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): try to sync yarn dependencies Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): fix encoding issue package.json Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): new version of getting podman desktop version Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): add missing working directory Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): add --platform to docker pull Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): add buildx to use linux images on windows Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): revert - add buildx to use linux images on windows This reverts commit 76ff106. test(e2e): build sso image locally too Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): missing pnpm install on sso extension Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): clean up, fix artifact upload Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): more cleanup + squash Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): added stacktrace to check why the test breaks Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): change path of sso extension build to correct one Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): revert try-catch clause, added e2e-tests job to e2e-main Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): removed unnecesary 'page' Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): skip local build on linux Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): build crc extension from dockerfile (test) Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): new version of local build Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): new version of local build but for sso extension as well Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): fixed path on previous commit Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): added missing folder Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): fixed target path Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): added target folder properly Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): print extension error during tests Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): revert - print extension error during tests This reverts commit e9a3566. test(e2e): fixed pathing issue? Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): fixed pathing issue (this time for real) Signed-off-by: Daniel Villanueva <[email protected]> test(e2e): clean up, add previous changes to e2e-main.yaml Signed-off-by: Daniel Villanueva <[email protected]>
danivilla9
force-pushed
the
382-automate-e2e-tests-windows
branch
from
b15e700 to
0018721
Compare
Signed-off-by: Daniel Villanueva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382