-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error tuples #24
Open
GeoffreyPS
wants to merge
33
commits into
master
Choose a base branch
from
error_tuples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Error tuples #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just remembered that this will also require use of Elixir version 1.2 or higher with use of the |
…ng variants. To do: update falling_factorial and rising_factorial to include error tuples; update n_choose_k to use new falling_factorial function.
to do: Extend test cases for other functions in the module.
…ng variants to do: Include cases where lists contain invalid information (like lists of non-number terms). Extend {:ok, reponse} return values for the remaining functions in the module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to issue #23 (Error Conventions)
If merged, this commit will:
result
to either{:ok, result}
or{:error, reason}
.Statisaur
functions have slightly different internal implementations, typically leveraging thewith
macro, but may usetry/rescue
blocks in rare instances.median/1
andmedian!/1
).These changes extend to the original
Statisaur
module andStatisaur.Combinatorics
module, as they are the only modules on the master branch.Please let me know if there are other actions I need to take before this can be merged (bumping version number, fixing anything, etc). Thanks for taking the time to review!