Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: eth_sender transaction's base fee is not capped #49

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

thomas-nguy
Copy link
Member

Solution:

add a cap to base fee

@JayT106
Copy link
Contributor

JayT106 commented Jul 8, 2024

Don't understand why caps the base fee in the eth sender, can you give more context?
In EIP-1559, there is no definition of the base fee cap but the base fee cannot exceeds the max gas fee.

@thomas-nguy
Copy link
Member Author

thomas-nguy commented Jul 9, 2024

Due to an issue on testnet, the l2_gas_price is capped to 10k
While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000

In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send l1 transactions when Ethereum gas_price is over 40gwei.

This is the idea of this cap.

@JayT106
Copy link
Contributor

JayT106 commented Jul 9, 2024

Due to an issue on testnet, the l2_gas_price is capped to 10k While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000

In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send l1 transactions when Ethereum gas_price is over 40gwei.

This is the idea of this cap.

I see.

@thomas-nguy thomas-nguy force-pushed the thomas/max-eth-sender-fee branch from 22784ce to c99e25f Compare July 10, 2024 02:55
@thomas-nguy thomas-nguy merged commit 6422305 into testnet-v24.2.0 Jul 10, 2024
4 of 11 checks passed
@thomas-nguy thomas-nguy deleted the thomas/max-eth-sender-fee branch July 19, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants