Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: No gkms-signer in v24.9.0 #53

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Problem: No gkms-signer in v24.9.0 #53

merged 5 commits into from
Jul 21, 2024

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jul 11, 2024 •
edited
Loading

Solution: cherry-pick #44 and #50

The env variable GOOGLE_KMS_OP_KEY_NAME and GOOGLE_KMS_OP_BLOB_KEY_NAME in #44 has been removed and using program env file to instead. I.e.

ETH_SENDER_SENDER_SIGNING_MODE=GcloudKms

ETH_SENDER_SENDER_GKMS_OP_KEY_NAME=projects/[project name]/locations/[project location]/keyRings/[key ring name]/cryptoKeys/[key name]/cryptoKeyVersions/[key version]

ETH_SENDER_SENDER_GKMS_OP_BLOB_KEY_NAME=...

@JayT106 JayT106 requested review from calvinaco and thomas-nguy July 11, 2024 17:28
@JayT106 JayT106 self-assigned this Jul 11, 2024
@JayT106 JayT106 marked this pull request as draft July 11, 2024 17:29
@calvinaco
Copy link
Collaborator

@JayT106 we should backport #54 into this branch.

@JayT106
Copy link
Contributor Author

JayT106 commented Jul 11, 2024

@JayT106 we should backport #54 into this branch.

#54 (comment)

@JayT106 JayT106 force-pushed the jt/gkms-signer-core-v24.9 branch from c92f299 to fd683a1 Compare July 11, 2024 17:54
@JayT106 JayT106 marked this pull request as ready for review July 12, 2024 16:27
@JayT106 JayT106 changed the title problem: no gkms-signer in v24.9.0 problem: No gkms-signer in v24.9.0 Jul 12, 2024
@JayT106 JayT106 changed the title problem: No gkms-signer in v24.9.0 Problem: No gkms-signer in v24.9.0 Jul 12, 2024
@JayT106 JayT106 changed the base branch from cronos-v24.9.0 to testnet-v24.9.0 July 19, 2024 13:51
@thomas-nguy thomas-nguy merged commit 0a7f696 into testnet-v24.9.0 Jul 21, 2024
16 of 25 checks passed
thomas-nguy pushed a commit that referenced this pull request Jul 22, 2024
@JayT106 @thomas-nguy
Problem: No gkms support for eth_signer (#53)
8e7862d
thomas-nguy pushed a commit that referenced this pull request Jul 25, 2024
@JayT106 @thomas-nguy
Problem: No gkms support for eth_signer (#53)
d265acd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco

Assignees

@JayT106 JayT106

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayT106 @calvinaco @thomas-nguy