Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: eth_sender transaction's base fee is not capped #82

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

thomas-nguy
Copy link
Member

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

Unknown release type "Problem" found in pull request title "Problem: eth_sender transaction's base fee is not capped". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@thomas-nguy thomas-nguy force-pushed the thomas/cap-eth-v24.23 branch from 412a267 to 5db2d45 Compare September 6, 2024 07:47
@thomas-nguy thomas-nguy force-pushed the thomas/cap-eth-v24.23 branch from 5db2d45 to 14ae56c Compare September 6, 2024 08:04
@thomas-nguy thomas-nguy merged commit ed23d29 into cronos-v24.23.0 Sep 6, 2024
8 of 50 checks passed
@thomas-nguy thomas-nguy deleted the thomas/cap-eth-v24.23 branch October 28, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant