Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing verification api for wc 2.0 (fix #474) #475

Merged
merged 1 commit into from
May 22, 2024

Conversation

leejw51crypto
Copy link
Collaborator

feat: enable personal signing in web3_v2.rs example
feat: Add personal signature verification method
feat: Update wallet_connect.cc to use Walletconnect2Client
feat: Update wallet_connect.cc to use Walletconnect2Client

@leejw51crypto leejw51crypto requested a review from a team as a code owner May 20, 2024 07:21
@leejw51crypto leejw51crypto requested review from rarcifa and damoncro May 20, 2024 07:31
@leejw51crypto leejw51crypto force-pushed the feature/474 branch 3 times, most recently from a80b28d to 0ba2c32 Compare May 20, 2024 17:28
Copy link

@rarcifa rarcifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. The only thing I am a bit confused is .address.address. Is this the new syntax to retrieve an address?

demo/examples/src/wallet_connect.cc Outdated Show resolved Hide resolved
demo/examples/src/wallet_connect.cc Outdated Show resolved Hide resolved
@leejw51crypto leejw51crypto force-pushed the feature/474 branch 3 times, most recently from f4eb002 to 8681bdc Compare May 22, 2024 10:41
feat: enable personal signing in web3_v2.rs example
feat: Add personal signature verification method
feat: Update wallet_connect.cc to use Walletconnect2Client
feat: Update wallet_connect.cc to use Walletconnect2Client

tidy up

reformat

change warning error level

chore: update cargo test command in CI workflow

chore: add RUSTFLAGS to enable dead code linting in CI workflow

chore: enable dead code linting in CI workflow

chore: update cargo test command in CI workflow

chore: update clippy command in CI workflow

feat: Update wallet_connect.cc to use Walletconnect2Client

feat: Update wallet_connect.cc to improve personal message signing and verification

feat: Fix c++ walletconnect example to use wc 2.0 and add verification for sign_personal

feat: Remove unnecessary include in wallet_connect.cc
@leejw51crypto leejw51crypto added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 9eaa34d May 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants