Allow MetricsReader to return point_ids for properties that are associated with multiple property name keys. #2
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MetricsReader._get_point_ids to return point_ids for device aliases that are associated with multiple property keys.
Issue: For some sites and devices, point_ids are associated with more than one property keys -- eg, both ReturnTemperature and ControlTemperature. When retrieving data for one of these keys, the current code compares the length of the two does the following:
The existing code compares
len(value_alias_list) == len(point_map.keys())
Since the length of values.alias_list = 2 and the length of point_map.keys() = 1, the function throws an error and no point_id is returned for either property.
Comparing the lengths of the sets instead returns the correct point_id and allows data to be retrieved for both properties.