Make RatesReader return a datetime object rather than an int #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlyRate objects that contain a timestamp for the start date, rather than an int. - Update the HourlyRate dataclass to expect a datetime object for the 'start' parameter. - Update RatesReader to unpack the returned values from the old HourlyRate object, get the timestamp using datetime.fromtimestamp, then return the new object
…s used when pulling the data and expect start datetimes coded as `int`; HourlyRate class is used when unpacking the data via RatesReader and expect start datetimes as datetime objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with the MetricsReader, RatesReader should return HourlyRate objects that contain a timestamp for the start date, rather than an int that must then be converted.