Update missing-signer-check lint to handle anchor programs separately #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the
missing-signer-check
lint to printAccounts
structs in anchor programs. The lint will highlight accounts that might need to be signers. It uses the type of the account to determine if the account should be reported.The lint will report accounts of type
AccountInfo
,UncheckedAccount
andSystemProgramAccount
. The chances of reported field being a false positive are high. But the number of results is bounded by the number of different#[derive(Accounts)]
structs.Example warning:
The tests need to be updated: The lint is updated to determine whether the Solana program is an anchor program. And based on that different logic is executed. The test programs are written using Anchor but the results are of the non-anchor logic. Have to discuss and make appropriate changes.