-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scaling to mobile and fixed a few build errors #176
Open
Finkoy
wants to merge
37
commits into
cs-education:master
Choose a base branch
from
Finkoy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few known bugs that haven't been fixed since the original version. The code editor still does not work and will probably have to be rewritten in order to get the Android keyboard to pop up. The return key on mobile phones seem to be malfunctioning (not create an extra space sometimes and deletes characters). The design is also not yet perfect and a bit unintuitive, but is usable. Upon pressing the text editor, other divs will close. However, the user must touch away (lose focus from the editor) in order to make the divs reappear. The text editor still looks small due to the popup keyboard on phones, so more work will be done to make it look better. Users can compile their code and view the results in the terminal. Tabs allow users to go through the text prompt, terminal, and text editor. The navigation bar now collapses for mobile devices and text editor settings collapse into a button. Additionally, the project should have fewer build errors. Ignore the various delete commits and possibly redundant comments; most of the work was done in one big commit.