Remove favs attribute if no favourites are set

changelog/unreleased/fix-empty-fav-attr.md

@@ -0,0 +1,5 @@
+Bugfix: no empty favs attr
+
+See issue #5016: we now unset the favs attr if no more favs are set
+
+https://github.com/cs3org/reva/pull/5017

pkg/eosclient/eosbinary/eosbinary.go

@@ -527,6 +527,9 @@ func (c *Client) handleFavAttr(ctx context.Context, auth eosclient.Authorization
 		favs.DeleteEntry(acl.TypeUser, u.Id.OpaqueId)
 	}
 	attr.Val = favs.Serialize()
+	if attr.Val == "" {
+		return c.UnsetAttr(ctx, auth, attr, false, path, "")
+	}
 	return c.setEOSAttr(ctx, auth, attr, false, recursive, path, "")
 }
 

pkg/eosclient/eosgrpc/eosgrpc.go

@@ -597,6 +597,9 @@ func (c *Client) handleFavAttr(ctx context.Context, auth eosclient.Authorization
 		favs.DeleteEntry(acl.TypeUser, u.Id.OpaqueId)
 	}
 	attr.Val = favs.Serialize()
+	if attr.Val == "" {
+		return c.UnsetAttr(ctx, auth, attr, false, path, "")
+	}
 	return c.setEOSAttr(ctx, auth, attr, false, recursive, path, "")
 }
 

pkg/storage/utils/acl/acl.go

@@ -79,6 +79,10 @@ func isComment(line string) bool {
 
 // Serialize always serializes to short text form.
 func (m *ACLs) Serialize() string {
+	if len(m.Entries) == 0 {
+		return ""
+	}
+
 	sysACL := []string{}
 	for _, e := range m.Entries {
 		sysACL = append(sysACL, e.CitrineSerialize())