Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend apply_forest and confusion_matrix as well #42

Closed
wants to merge 5 commits into from
Closed

Conversation

dhanak
Copy link
Member

@dhanak dhanak commented Sep 29, 2023

Analogously to build_forest, extend DecisionTree's apply_forest and confusion_matrix functions to accept instances of FeatureSet as a second argument, for convenience.

Also cleanup the imports and exports of the main module slightly.

@dhanak dhanak requested a review from ovnora September 29, 2023 14:52
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/FeatureScreening.jl 100.00% <100.00%> (ø)
src/Types.jl 86.09% <100.00%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@dhanak dhanak force-pushed the dev branch 8 times, most recently from 61683ea to 1322109 Compare September 29, 2023 16:36
Analogously to `build_forest`, extend `DecisionTree`'s `apply_forest`
and `confusion_matrix` functions to accept instances of `FeatureSet` as
a second argument, for convenience.

Also cleanup the imports and exports of the main module slightly.
* adjust `Project.toml` to make project compatible with any Julia 1.*;
* add explicit dependency updates to CI.yml;
* use latest Julia 1.* for CI tests (in addition to 1.6 for backward
  compatibility checks).
@dhanak dhanak force-pushed the dev branch 4 times, most recently from 39e28ca to 69bb83c Compare October 10, 2023 16:01
@dhanak
Copy link
Member Author

dhanak commented Oct 10, 2023

Fixes #38 and #41

@dhanak dhanak closed this in 2b7df92 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants