PR Template Updates (#22)

* Adding D&A Dependencies reminder to PR Template * Making Tailor Made & Premium Blend owners of PR Template * Use warning emoji for risk levels in PR template --------- Co-authored-by: Christopher R. Murphy <[email protected]>
customink · Apr 4, 2024 · 172c5c3 · 172c5c3
1 parent 28548a5
commit 172c5c3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1 +1,3 @@
 * @customink/atlas
+
+.github/pull_request_template.md @customink/tailor-made @customink/premium-blend
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -8,11 +8,11 @@ Provide a concise summary of the motivation and the driving force behind this ch
 _[Replace this with a description of the risk, if any, and how the change will be deployed.]_
 
 <!-- remove any that do not apply -->
-- ✅ Big/complex change
-- ✅ Big splash zone
-- ✅ High stakes if errors occur
-- ✅ Low confidence
-- ✅ Not hidden by feature flag
+- ⚠️ Big/complex change
+- ⚠️ Big splash zone
+- ⚠️ High stakes if errors occur
+- ⚠️ Low confidence
+- ⚠️ Not hidden by feature flag
 - ✅ Negligible risk!
 
 ### Changes
@@ -69,6 +69,11 @@ Common, optional tasks are included here in case you forgot something important.
 - Are there any new queries in your change set that might require new indexes?
 - Do any new queries require time-boxing to avoid table-scans when the data grows?
 
+
+##### Data & Analytics Dependencies
+- For customer-facing applications, are there any GA tagging changes that are needed or created by this change? If so, have those been discussed with D&A?
+- Has Data Engineering been notified of any schema changes?
+
 ### What GIF Best Describes This Pull Request?
 
 <!--
Original file line number	Diff line number	Diff line change
		@@ -1 +1,3 @@
		* @customink/atlas

		.github/pull_request_template.md @customink/tailor-made @customink/premium-blend