chore: generate applyconfigurations for APIs (SSA) #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
generate-ac
branch
2 times, most recently
from
a2d9cc9 to
d680a31
Compare
erikgb
changed the title
|
@erikgb |
Oh yes, that is my plan in the next PR. |
zoetrope
reviewed
Nov 15, 2023
| applyconfiguration-gen: $(APPLYCONFIGURATION_GEN) ## Download applyconfiguration-gen locally if necessary | ||
| $(APPLYCONFIGURATION_GEN): | ||
| # see https://github.com/kubernetes/code-generator/tree/master/cmd/applyconfiguration-gen | ||
| GOBIN=$(shell pwd)/bin go install k8s.io/code-generator/cmd/[email protected] |
There was a problem hiding this comment.
We are using aqua to manage packages for accurate to automate package updates using renovate.
We would like to manage applyconfiguration-gen with aqua as well.
But that is a bit complicated. I will create a PR for that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generation of applyconfigurations to facilitate type-safe SSA for custom resources. I have made the generated types internal for now, and only for the newer version of our API. The upstream generator is built for Kubernetes, requiring minor tweaks to the project layout.
I plan to migrate the SubNamespace controller to SSA when introducing the new API version (
v2alpha1).Please take a look and tell me what you think! I'll be happy to reduce the number of changes in this PR.
CC @zoetrope @ymmt2005