feat: enable v2alpha1 API with conversion webhook #107
Conversation
|
@zoetrope @ymmt2005 Do you have any suggestions on how to solve the CRD issue in the Helm chart? It won't work as it stands now, and an additional problem is that Helm is unable to template CRD. For this reason, several open-source projects have moved the CRDs out of the Helm crds folder. And provides a Helm value to control if CRDs are provisioned or not. Helm has never had proper support for CRDs, and I think they have given up now. Please take a look at how cert-manager, which I know pretty well "solves" the Helm issue: https://cert-manager.io/docs/installation/helm/#3-install-customresourcedefinitions If you think that's a good approach, I can prepare a preparation PR making the CRDs possible to template. And then I can progress on this PR. |
erikgb
force-pushed
the
conversion-webhook
branch
2 times, most recently
from
2e5757d to
2c7c35d
Compare
|
@erikgb I agree that it seems like a very good approach. |
Thanks for the feedback. I will prepare a PR. |
erikgb
force-pushed
the
conversion-webhook
branch
3 times, most recently
from
977c797 to
9679ae2
Compare
erikgb
force-pushed
the
conversion-webhook
branch
from
9679ae2 to
aec6020
Compare
erikgb
changed the title
|
@zoetrope I think this PR is ready for review now. I have also added a simple e2e-test to check conversion works. Next PR will be a lot more interesting - I think. 😸 |
This PR makes the new v2alpha1 version of the API served and enables the conversion webhook using logic established in #96.
After this, I will suggest changing the SubNamespace controller to watch/reconcile version v1alpha1 (using SSA). When the controller watches v2alpha1 version, I think it also makes sense to switch the stored version.