Make admin privileges configurable #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
force-pushed
the
remove-too-permissive-rbac
branch
5 times, most recently
from
9c19f30 to
2b50aa1
Compare
ymmt2005
requested review from
zoetrope,
morimoto-cybozu,
zeroalphat and
d-kuro
ymmt2005
commented
Sep 27, 2023
| @@ -49,7 +49,11 @@ Run and try Accurate on a [kind (Kubernetes-In-Docker)][kind] cluster as follows | |||
|
|
|||
| 3. Install [aqua][]. | |||
|
|
|||
| https://aquaproj.github.io/docs/tutorial-basics/quick-start | |||
There was a problem hiding this comment.
This page no longer exists.
|
@ymmt2005 |
Fix #82. With this change, we stop granting the below permission to the accurate controller. ```yaml - apiGroups: - '*' resources: - '*' verbs: - get - list - watch ``` Also, we make the ClusterRole admin optional. The Helm chart now takes optional ClusterRoles to be granted.
ymmt2005
force-pushed
the
remove-too-permissive-rbac
branch
from
2b50aa1 to
f8bff61
Compare
erikgb
suggested changes
Sep 27, 2023
There was a problem hiding this comment.
The changes look good to me, but I think this should be removed: https://github.com/cybozu-go/accurate/blob/main/controllers/propagate.go#L57, and then run controller-gen.
|
Thanks. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #82.
With this change, we stop granting the below permission to the
accurate controller.
Also, we make the ClusterRole
adminoptional.The Helm chart now takes optional ClusterRoles to be granted.