Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate propagate-generated feature #95

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Oct 14, 2023

As agreed in #87 (comment) we think it's time to initiate the removal of the propagate-generated feature. This PR does:

  • update docs to inform about the deprecated feature
  • mark affected code as deprecated

Relates to #87
Close #93

@erikgb
Copy link
Contributor Author

erikgb commented Oct 14, 2023

@ymmt2005 @zoetrope Please review this semi-ready PR. I was struggling a bit to find a good way of "styling" the deprecated feature in the docs. The current state of this PR is my proposal, but feel free to suggest other ways of doing this.

@erikgb erikgb force-pushed the deprecate-propagate-generated branch from 8b3bb28 to 6b5d916 Compare October 14, 2023 11:39
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 9bbac9f into cybozu-go:main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: better example for propagate generated
2 participants