Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide feedback for old operating systems that don't support protocol #27910

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

Provide better error messaging and feedback for old operating systems that don't support protocol

Steps to test

The new system test handles this scenario

How has the user experience changed?

n/a

PR Tasks

@cypress
Copy link

cypress bot commented Sep 26, 2023

24 flaky tests on run #51286 ↗︎

0 28124 1345 0 Flakiness 24

Details:

fix: provide feedback for old operating systems
Project: cypress Commit: 9f31c580a4
Status: Passed Duration: 19:16 💡
Started: Sep 26, 2023 7:06 PM Ended: Sep 26, 2023 7:25 PM
Flakiness  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
scaffolding component testing > vuecli5vue3 > scaffolds component testing for Vue CLI 5 w/ Vue 3 project Test Replay Output Screenshots
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > opens the run page if a run is clicked Test Replay Output Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 13 specs in Cypress Cloud.

Review all test suite changes for PR #27910 ↗︎

@MikeMcC399
Copy link
Contributor

@ryanthemanuel

@ryanthemanuel
Copy link
Collaborator Author

@ryanthemanuel

Hi @MikeMcC399, we originally were going to try and provide guidance to users to get their systems in line with minimum versions of GLIBC that is necessary for using better-sqlite3 (which is necessary for protocol), but we are actually going to switch gears for this issue as we think we have a way to resolve it in such a way that users don't need to do anything OS-wise. Stay tuned, but I hope to have a PR out for that relatively soon.

@ryanthemanuel
Copy link
Collaborator Author

Closed in lieu of #27968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants