imapd: don't auto-expunge if replicaonly #5164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfsage
requested changes
Dec 10, 2024
| @@ -5004,10 +5009,13 @@ static void cmd_close(char *tag, char *cmd) | |||
| } | |||
|
|
|||
| /* local mailbox */ | |||
| if ((cmd[0] == 'C' || config_getswitch(IMAPOPT_AUTOEXPUNGE)) && index_hasrights(imapd_index, ACL_EXPUNGE)) { | |||
| if (cmd[0] == 'C') { | |||
There was a problem hiding this comment.
This looks like a mistake - now we'll call index_expunge(imapd_index, NULL, 1) on close without checking if they have EXPUNGE rights, when before we'd check
If I open two ctel sessions, and do x SELECT INBOX and then x STORE 1 +Flags \Deleted in one, and then in the other I do x EXAMINE INBOX and x CLOSE, imapd crashes with:
2024-12-10T10:02:19.351166-05:00 box-fastmail-01 (err) slotf1n01/imapadmin[3149412]: Internal error: assertion failed (aborting): imap/mailbox.c: 4516: mailbox_index_islocked(mailbox, 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up where a test script was logging into a replica and SELECTing the INBOX. If there was a DELETED message that wasn't expunged, then it would try to write quote while expunging on the replica, and fail an assert.
This simplifies the code by putting it in a function.