Fix conversations issues #5181
Open
Fix conversations issues #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
reviewed
Dec 20, 2024
wolfsage
reviewed
Dec 20, 2024
This matches the logic in mailboxes.c, and makes audit tests pass
This stops us writing to the wrong DB when copying the INBOX, which fixes a long standing bug with UUID mailboxes and renames. This fixes both the imapd rename, and the replication rename codepaths.
This just makes it easier to read
|
@wolfsage both your comments are fixed in 75509c3 @ksmurchison - the fixes above also fixed the Replication test! Yep, looks like it was a bug before. |
wolfsage
reviewed
Dec 23, 2024
| int r2 = mboxlist_update_full(olddestmbentry, /*localonly*/1, /*silent*/1); | ||
| if (r2) | ||
| xsyslog(LOG_ERR, "IOERROR: replacing old destination tombstone after rename error", | ||
| "mboxname=<%s>, error=<%s>", olddestmbentry->name, error_message(r)); |
There was a problem hiding this comment.
In all four cases here should we also be logging error_message(r2) so we know why the cleanup failed?
"mboxname=<%s>, error=<%s>, cleanuperror=<%s>", oldestmbentry->name, error_message(r), error_message(r2));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two issues here:
basecid inconsistency causing TEMP/REAL mismatch
poor inbox detection on user rename causing bigger issues. The second one is ALSO a known Fastmail issue on user rename, such that we do a full conversations rebuild after renaming. This will fix that.
The reason these weren't detected earlier is that
ctl_conversationsdb -AONLY works on databases which support fetchnext, which skiplist doesn't, so we didn't notice these until switching to make twoskip the default.