Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtests.py: Fixed an issue where the return value of the function is incorrect. #747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winner658
Copy link

@winner658 winner658 commented Aug 29, 2022

Fixed an issue where the return value of the function is incorrect.https://github.com/cyrusimap/cyrus-sasl/issues/746
When the gssapi_channel_binding_mismatch_test function is bound successfully, 0 is returned. When an exception occurs, 1 is returned. The function is consistent with other functions of the same type.

Signed-off-by: Winner658 [email protected]

Fixed an issue where the return value of the function is incorrect.
@bgermann
Copy link
Contributor

bgermann commented Jul 7, 2023

The Signed-off-by has to be in the commit message, not in the PR description.

@quanah quanah added this to the 2.2.0 milestone Jul 18, 2023
@quanah quanah self-requested a review August 24, 2023 15:22
@quanah quanah self-assigned this Aug 24, 2023
@mistotebe
Copy link
Contributor

Except this test is making sure that the exchange actually fails (in which case it returns 0 - success), so the right way around would be to fix the messages emitted. And probably make sure that the result of plain_tests() contributes to err.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants