Set version status to PENDING in ingest_zarr_archive #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
requested changes
Dec 17, 2024
jjnesbitt
force-pushed
the
ingest-zarr-dandiset-metadata
branch
from
cb3c4a7 to
eb6fb85
Compare
mvandenburgh
approved these changes
Dec 17, 2024
jjnesbitt
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2091
@mvandenburgh The last commit fixes some zarr tests that didn't have a draft version associated with their dandiset, due the chain of
SubFactorydefinitions. I originally tried to fix this on theDandisetFactoryclass itself, so that all dandisets generated in this way would always have a draft version, but that proved troublesome. For now, I've settled for just fixing the zarr tests.