Fix inconsistent padding on Contributors card in DLP #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MetadataCard` wraps its contents in a `v-row` and `v-col`, which adds some additional padding around the card. The "Contributors" card, however, is the only DLP card that doesn't use the `MetadataCard` component. Prior to this change, the "Contributors" card didn't use `v-row` and `v-col`, so it didn't have the same padding as the other cards.
See previous commit about `Contributors` card, this is the same issue.
|
note:we do not have netlify previews here likely because merge is into another PR branch for #2103 . I will "rebase and merge" . |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MetadataCardcomponent wraps its contents in av-rowandv-col, which adds some additional padding around the card. The "Contributors" card, however, is the only DLP card that doesn't use theMetadataCardcomponent. Prior to this change, the "Contributors" card didn't usev-rowandv-col, so it didn't have the same padding as the other cards.