-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login to docker hub only if credentials were provided #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this could be the only solution (may be besides also adding retries in addition) to allow testing against dandi-cli to be done also in PRs from forks of the project, where there is no credentials. We could also advise our developers to provide such (own) credentials in their forks. FTR: login originally was added in 6b815dc ref: dandi#2107
jwodder
requested changes
Dec 19, 2024
success as we did build image without credentials:
the fails are actually due to that
I will be addressing @jwodder comment and will see if could fix it while at this |
scrape above "comment" - sure thing it broke testing of dandi-cli since we need now to fix it up there too! ;-) |
jwodder
requested changes
Dec 19, 2024
FTR -- build image is fine again! |
Co-authored-by: John T. Wodder II <[email protected]>
mvandenburgh
approved these changes
Dec 19, 2024
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this could be the only solution (may be besides also adding retries in addition) to allow testing against dandi-cli to be done also in PRs from forks of the project, where there is no credentials. We could also advise our developers to provide such (own) credentials in their forks.
FTR: login originally was added in 6b815dc