Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login to docker hub only if credentials were provided #2118

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 19, 2024

I think this could be the only solution (may be besides also adding retries in addition) to allow testing against dandi-cli to be done also in PRs from forks of the project, where there is no credentials. We could also advise our developers to provide such (own) credentials in their forks.

FTR: login originally was added in 6b815dc

I think this could be the only solution (may be besides also adding retries in addition)
to allow testing against dandi-cli to be done also in PRs from forks of the project,
where there is no credentials.  We could also advise our developers to provide such (own)
credentials in their forks.

FTR: login originally was added in 6b815dc

ref: dandi#2107
.github/workflows/cli-integration.yml Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member Author

success as we did build image without credentials:

Not login-in to docker since no credentials were provided, might hit limits below
14
#0 building with "default" instance using docker driver
15

16
#1 [internal] load build definition from django-public.Dockerfile
17
#1 transferring dockerfile: 373B done
18
#1 DONE 0.0s

the fails are actually due to that

I will be addressing @jwodder comment and will see if could fix it while at this

@yarikoptic
Copy link
Member Author

scrape above "comment" - sure thing it broke testing of dandi-cli since we need now to fix it up there too! ;-)

.github/workflows/cli-integration.yml Outdated Show resolved Hide resolved
@yarikoptic yarikoptic requested a review from jwodder December 19, 2024 17:31
@yarikoptic
Copy link
Member Author

FTR -- build image is fine again!

Co-authored-by: John T. Wodder II <[email protected]>
@yarikoptic yarikoptic merged commit 9bf49de into dandi:master Dec 19, 2024
11 checks passed
@dandibot
Copy link
Member

🚀 PR was released in v0.4.2 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI can't read GitHub Actions secrets on fork-based PRs
4 participants