Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs to web view #73

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add breadcrumbs to web view #73

merged 4 commits into from
Feb 14, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 14, 2024

Closes #14.

Screenshot in Safari:

breadcrumbs

Styling of individual breadcrumbs has been deferred to #72.

In addition, while refactoring in order to implement breadcrumbs, the check for ".git" and similar components in request paths (to trigger an early 404) was made case-insensitive.

@jwodder jwodder added enhancement New feature or request therefor ui:web Relating to the web interface labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (19da772) 35.57% compared to head (6651775) 36.71%.

Files Patch % Lines
src/dav/html.rs 0.00% 18 Missing ⚠️
src/dav/mod.rs 0.00% 17 Missing ⚠️
src/dav/path.rs 98.38% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   35.57%   36.71%   +1.13%     
==========================================
  Files          24       24              
  Lines        3320     3435     +115     
==========================================
+ Hits         1181     1261      +80     
- Misses       2139     2174      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder merged commit 4998bd8 into main Feb 14, 2024
10 checks passed
@jwodder jwodder deleted the gh-14 branch February 14, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request therefor ui:web Relating to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "breadcrumbs" in web view
1 participant