Avoid importing zarr library unless necessary #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run poetry version patch
jjnesbitt
approved these changes
Nov 14, 2023
|
Since I guess we would need a released version for dandi-cli, marking it for a release. |
|
oh, this is not |
|
@yarikoptic My understanding is that all PRs in this repo get a release automatically unless the "skip-release" label is present. This repo doesn't use auto, so I don't think the "internal" label does anything for releases. |
|
you are right -- I think it is this workflow https://github.com/dandi/zarr_checksum/blob/master/.github/workflows/python-publish.yml which does it. Cool. So we just need a merge I guess. Let's wait a tiny bit for an authority to give blessing. |
jwodder
added a commit
to dandi/dandi-cli
that referenced
this pull request
Nov 27, 2023
- We can't update to `zarr_checksum` 0.3.0 yet, as that requires Pydantic v2. - As `zarr_checksum` gained type annotations in dandi/zarr_checksum#21, we can remove its override from the mypy config. - Since dandi/zarr_checksum#17 was merged, it's now safe to import `zarr_checksum` at the top level of a module. - Fixed a typing error caused by importing `ZarrChecksumTree` from the top level of `zarr_checksum` despite it not being listed in `zarr_checksum.__all__`, which triggered a typing failure due to our mypy configuration containing `implicit_reexport = False`. (This error could only be detected after `zarr_checksum` started shipping a `py.typed` file.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, importing
zarr_checksumautomatically & unconditionally causeszarrto be imported as well, which results innumpybeing imported, which is not good for dandi-cli's "no heavy imports" test. This PR moves the single import ofzarrto inside the only function that makes use of it.