Update README #440
Update README #440
Conversation
…utomatic search in danger directory
|
|
||
| ```swift | ||
| swift run danger-swift command --cwd path/to/working-directory | ||
| swift run --package-path path/to/working-directory danger-swift command --cwd path/to/working-directory |
There was a problem hiding this comment.
--package-path and --cwd do almost the same thing, but in different ways (so you shouldn't need --cwd if you have --package-path), but --package-path doesn't work in all the cases, it has still some corner cases that needs to be handled, and this is why it is not suggested yet, once it fully supported cwd should be deprecated.
The correct command should be cd path && swift run danger ci --cwd rootFolder
| swift run --package-path path/to/working-directory danger-swift command --cwd path/to/working-directory | ||
| ``` | ||
|
|
||
| Keep in mind that Danger will automatically search for your Dangerfile in a `danger` directory placed at the root of your project. So if you put your `Dangerfile.swift` and `Package.swift` in a `danger` directory you can leave off the `--cwd` parameter (though, you still have to specify your package path to `swift run`) |
There was a problem hiding this comment.
You can use the --dangerfile parameter to specify the Dangerfile you want to run, there is no need to use cwd in that case I think, you can use --package-path and --dangerfile
There was a problem hiding this comment.
IMHO, there is no information about --dangerfile parameter in any reference or documents, and should be written in the README🤔.
|
Thank you for the PR, just some comments about the --package-path :) |
I added a few missing details to the README when using the
--cwdparameter, as well as pointed out that Danger will automatically search for your Dangerfile in adangerdirectory, as well as fixed some grammar.