Gr sink #608
Merged
Gr sink #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 5, 2024 14:39
…ce between the sinks only
added 9 commits
December 10, 2024 17:44
… explicitly imported at (1) that I got on github tests run
danieljprice
requested changes
Dec 13, 2024
|
the remaining failure here is when running phantomsetup in grtde with DEBUG=yes, and is caused by variables that are used while being uninitialised (hence set to NaN). Can be debugged with: where only Enter is allowed as input and you can run phantomsetup up to 3 times to recreate the .setup file |
danieljprice
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
New physics
Description:
Can have sink particles in GR code
Testing:
test is written in test_ptmass.f90
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no