This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Debug report #361
Draft
Debug report #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
reviewed
Feb 21, 2020
| if [ "$PNAME" == "null" ]; | ||
| echo "Please set a name in config.json" | ||
| exit 1 | ||
| fi | ||
| export PNAME |
There was a problem hiding this comment.
Meaning what is PNAME usde for? It's passed to the setup script, which decides whether to create a project reports dir based on its presence.
There was a problem hiding this comment.
I mean why do we need to export PNAME if it's already set? I'm probably just missing some bash knowledge...
There was a problem hiding this comment.
It's to make it available to child processes. Now we passi it explicitly to setup-ci-project, so it's possible we could remove it.
d-xo
reviewed
Feb 21, 2020
libexec/klab-prove-all
Outdated
Comment on lines
36
to
39
| if [ "$PNAME" == "null" ]; | ||
| echo "Please set a name in config.json" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
do we also need to do smth similar for "$KLAB_REPORT_DIR"?
Stop branching on so many variables existing.
Let's simplify the execution flow.
For better greppability.
d-xo
force-pushed
the
debug-report
branch
2 times, most recently
from
11d9669 to
4603866
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For visibility.