-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
middleware: add wasm basic #1747
Conversation
Signed-off-by: Loong <[email protected]>
@shubham1172 could you help check the exact error of fossa? And where is the webapp:
|
@daixiang0 you can check out the Dapr project once you login to https://app.fossa.com/projects |
@yaron2 could you take a look? |
@daixiang0 please resolve the conflict. |
ping @daixiang0 |
Can you give an example here of how a component YAML would look like for WASM? |
@yaron2 component should look like this if I'm understanding this PR correctly
|
@berndverst totally correct! Thanks for lint fixing by the way. |
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
- Coverage 36.59% 36.58% -0.02%
==========================================
Files 177 178 +1
Lines 16222 16350 +128
==========================================
+ Hits 5937 5982 +45
- Misses 9617 9682 +65
- Partials 668 686 +18
Continue to review full report at Codecov.
|
What is the WASM interface or structure? any guidance here? Also, can this be used with Pub/Sub or just HTTP service invocation? |
@ewassef sorry about the large delay in responding. I'm just reviewing old issues for the dapr talk at kubecon EU next week.
Since this PR landed, we had requests to make the model more flexible. We wrote a specification and some SDKs for http-wasm, though currently this is only used by dapr (PR for mosn has been paused due to resources) So, as of v1.10 this feature is more fleshed out and documented and has a sample, also. About Pub/Sub, the closest we have in progress now is the output binding, which is incomplete, but I plan to help with this after KubeCon EU next week. It is pure WASI, so there's no pre-defined model (basically you interact via stdin or CLI args). You can subscribe to this issue which I think is prematurely closed as we haven't documented or integrated it into dapr, yet. |
Signed-off-by: Loong [email protected]
Description
Basic WASM HTTP middleware implement.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1171
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: