Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Add Python samples to patterns doc #3519

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

cgillum
Copy link
Contributor

@cgillum cgillum commented Jun 8, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR updates the workflow patterns doc with Python code examples.

Issue reference

Closes #3496

@hhunter-ms hhunter-ms added this to the 1.11 milestone Jun 8, 2023
@cgillum cgillum marked this pull request as ready for review June 8, 2023 23:36
@cgillum cgillum requested review from a team as code owners June 8, 2023 23:36
@cgillum
Copy link
Contributor Author

cgillum commented Jun 8, 2023

@msfussell @hhunter-ms this is ready for review. However, I wasn't able to view it locally due to the following error:

> hugo server
Start building sites … 
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended windows/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
Error: Error building site: "C:\GitHub\dapr-docs\daprdocs\content\en\_index.md:10:1": failed to extract shortcode: template for shortcode "alert" not found
Built in 1779 ms

Is there a known problem with the docs build? I noticed the link validator in the CI also isn't working but that seems unrelated.

@greenie-msft
Copy link
Collaborator

@msfussell @hhunter-ms this is ready for review. However, I wasn't able to view it locally due to the following error:

> hugo server
Start building sites … 
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended windows/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
Error: Error building site: "C:\GitHub\dapr-docs\daprdocs\content\en\_index.md:10:1": failed to extract shortcode: template for shortcode "alert" not found
Built in 1779 ms

Is there a known problem with the docs build? I noticed the link validator in the CI also isn't working but that seems unrelated.

There is an issue but we suspect it's related to the version of mistune that was updated recently and is a dependency of Mechanical Markdown (link validation tool).

I suspect the error you're encountering is unrelated? Looking into it now.

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 7aeab68 into dapr:v1.11 Jun 9, 2023
@cgillum cgillum deleted the wf-patterns-python branch June 10, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants