-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow] Add Python samples to patterns doc #3519
Conversation
Signed-off-by: Chris Gillum <[email protected]>
Signed-off-by: Chris Gillum <[email protected]>
Signed-off-by: Chris Gillum <[email protected]>
…docs into wf-patterns-python
Signed-off-by: Chris Gillum <[email protected]>
@msfussell @hhunter-ms this is ready for review. However, I wasn't able to view it locally due to the following error: > hugo server
Start building sites …
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended windows/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
Error: Error building site: "C:\GitHub\dapr-docs\daprdocs\content\en\_index.md:10:1": failed to extract shortcode: template for shortcode "alert" not found
Built in 1779 ms Is there a known problem with the docs build? I noticed the link validator in the CI also isn't working but that seems unrelated. |
There is an issue but we suspect it's related to the version of mistune that was updated recently and is a dependency of Mechanical Markdown (link validation tool). I suspect the error you're encountering is unrelated? Looking into it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-patterns.md
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-patterns.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR updates the workflow patterns doc with Python code examples.
Issue reference
Closes #3496