Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support for workflows #632

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

elena-kolevska
Copy link
Contributor

Description

Adds TLS support for workflows

Issue reference

#631

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation - N/A

@elena-kolevska elena-kolevska marked this pull request as ready for review November 1, 2023 12:59
@elena-kolevska elena-kolevska requested review from a team as code owners November 1, 2023 12:59
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d0007a9) 86.22% compared to head (6caf1f9) 86.16%.
Report is 2 commits behind head on main.

❗ Current head 6caf1f9 differs from pull request most recent head 38bdbc0. Consider uploading reports for the commit 38bdbc0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   86.22%   86.16%   -0.06%     
==========================================
  Files          75       75              
  Lines        3724     3737      +13     
==========================================
+ Hits         3211     3220       +9     
- Misses        513      517       +4     
Files Coverage Δ
dapr/clients/exceptions.py 90.90% <100.00%> (+0.90%) ⬆️
dapr/clients/http/client.py 94.91% <75.00%> (ø)
...workflow/dapr/ext/workflow/dapr_workflow_client.py 93.33% <84.61%> (-4.11%) ⬇️
...ext-workflow/dapr/ext/workflow/workflow_runtime.py 69.76% <71.42%> (-0.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska changed the title Tls workflows TLS for workflows Nov 1, 2023
@elena-kolevska elena-kolevska changed the title TLS for workflows TLS support for workflows Nov 1, 2023
@berndverst berndverst merged commit e15f515 into dapr:main Nov 1, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants