Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents usage of DAPR_API_TOKEN #654

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

elena-kolevska
Copy link
Contributor

Description

Documented the usage of DAPR_API_TOKEN

Issue reference

#653

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ee22eb) 86.16% compared to head (b810adb) 86.16%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files          75       75           
  Lines        3737     3737           
=======================================
  Hits         3220     3220           
  Misses        517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mukundansundar
mukundansundar previously approved these changes Jan 4, 2024
@@ -66,6 +69,9 @@ with DaprClient() as d:
The legacy environment variables `DAPR_RUNTIME_HOST`, `DAPR_HTTP_PORT` and `DAPR_GRPC_PORT` are
also supported, but `DAPR_GRPC_ENDPOINT` takes precedence.

##### Dapr API Token

You can use the `DAPR_API_TOKEN` environment variable to set the Dapr API token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elena-kolevska what do you think about linking to Enable API token authentication in Dapr, or the Environment variables doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks! I added it.

Signed-off-by: Elena Kolevska <[email protected]>
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@berndverst berndverst merged commit 5c10b78 into dapr:main Jan 9, 2024
5 of 8 checks passed
litan1106 pushed a commit to litan1106/dapr-python-sdk that referenced this pull request Jan 10, 2024
* Documents usage of `DAPR_API_TOKEN`

Signed-off-by: Elena Kolevska <[email protected]>

* Adds link to dapr api token docs

Signed-off-by: Elena Kolevska <[email protected]>

---------

Signed-off-by: Elena Kolevska <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Signed-off-by: Li Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants