added ruff lint and format #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Tan <[email protected]>
…vities (dapr#651) * initial code for decorators and optional naming of workflows and activities Signed-off-by: Mukundan Sundararajan <[email protected]> * add alternater_name decorator Signed-off-by: Mukundan Sundararajan <[email protected]> * fix linter Signed-off-by: Mukundan Sundararajan <[email protected]> * address review comments. Signed-off-by: Mukundan Sundararajan <[email protected]> * address review comments. Signed-off-by: Mukundan Sundararajan <[email protected]> --------- Signed-off-by: Mukundan Sundararajan <[email protected]>
* Documents usage of `DAPR_API_TOKEN` Signed-off-by: Elena Kolevska <[email protected]> * Adds link to dapr api token docs Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Li Tan <[email protected]>
litan1106
force-pushed
the
Add-ruff-linter
branch
from
b0c1e73 to
d042153
Compare
berndverst
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Please recreate the PR against the latest changes in main branch. I see you have some merge commit markers some places.
We want to continue using flake8 as our only linter, but ruff as autoformatter looks good..
After making your changes using ruff, please also run tox -e py311 (if you use Python 3.11, otherwise use py312 etc), tox -e type, tox -e flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to use it?
tox -e ruffto auto-format codeIssue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: