-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling #659
Error handling #659
Conversation
@berndverst pls let me know if the DaprGrpcError design and naming look ok to you. I would also like to get your opinion on the integration testing approach I took. I think it can be helpful for other cases too. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 86.21% 86.37% +0.15%
==========================================
Files 79 79
Lines 3998 4094 +96
==========================================
+ Hits 3447 3536 +89
- Misses 551 558 +7 ☔ View full report in Codecov by Sentry. |
LGTM. Can you resolve the conflict now that I merged the ruff stuff :) |
Marking this ready so the code can be reviewed while I'm working on examples and docs. |
Ok, examples and docs are ready :) |
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
9ecd3a7
to
b67960a
Compare
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
I addressed the review comments and I simplified the DaprGrpcError structure. 🙏 |
Signed-off-by: Bernd Verst <[email protected]>
I now updated the tox configuration to include your error handling test app. I am expected it to fail (it fails for me locally). You'll have to debug that one some more. |
If this PR requires Dapr 1.13, please let me know. In that case we will not be able to successfully run the CI tests until we have Dapr 1.13.0rc1 tagged |
Signed-off-by: Elena Kolevska <[email protected]>
Yes, that's exactly it! I could only test it with my local dapr build and had to make the following modifications to the README to make it pass:
Unfortunately, I had also commented out all the other examples in the tox.ini so it only ran my test while I was working on it, to keep it faster, but when I was committing, I also reverted the line that added my errors test by mistake. Sorry about that! |
Signed-off-by: Bernd Verst <[email protected]>
I will rerun tests and merge this when 1.13.0rc1 has been tagged. At that point this should all pass :) (I tried it locally with a Dapr build from master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the error handling docs 🎉
Description
Improves developer experience on error handling for the new Rich gRPC Errors from Dapr
Issue reference
#648
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: