Return Result when creating DaprHttpServer #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
http-server-error-handling
branch
from
c5c3ba1 to
6d4339e
Compare
Especially when running custom docker setups, the container that contains the sidecar may not be running exactly when the Rust code starts running. To fix this, before we needed to sleep(2s) to avoid a panic in the Rust program. With this patch, this can be handled on the user side (e.g. the connection can be retried multiple times with timeouts in-between). Signed-off-by: Leon Matthes <[email protected]>
LeonMatthesKDAB
force-pushed
the
http-server-error-handling
branch
from
6d4339e to
e86e915
Compare
mikeee
approved these changes
Dec 10, 2024
|
Thank you for this refactor - really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Especially when running custom docker setups, the container that
contains the sidecar may not be running exactly when the Rust code
starts running.
To fix this, before we needed to sleep(2s) to avoid a panic in the Rust
program.
With this patch, this can be handled on the user side (e.g. the
connection can be retried multiple times with timeouts in-between).
Issue reference
None
Checklist