Add WithNoOverrideEmptyStructValues #179
Conversation
|
Hello, @cwarden! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Add option to not overwrite empty fields in destination structs if the structs are not empty.
cwarden
force-pushed
the
do-not-overwrite-empty-values-within-non-empty-struct
branch
from
9ddaab6 to
424e4b2
Compare
|
I'm not positive that this needs a new option. If it does, perhaps it should be generalized to more than structs or to depths other than zero. Please take a look at the tests. Thoughts? |
Allow help text to be set to an empty string. See darccio/mergo#179.
|
@cwarden Sorry it took so long. The tests look fine, but I'm not sure if this PR can introduce unknown side effects. It looks you have been using your fork for a year. Did you find anything wrong during this time? |
|
Hi @imdario. This change has been working well for me in https://github.com/ForceCLI/force-md. |
|
This will be considered as part of v2. |
Add option to not overwrite empty fields in destination structs if the
structs are not empty.