-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyPath: add parameter followLinks #97
Conversation
`Directory.listSync` only returns `Link` entries if `followLinks: false` is passed. `copyPath` needs a `followLinks` parameter to configure the call of `Directory.listSync` and allow the copy of `Link` entries, as expected by line `else if (file is Link) {`
Can you add a test and a CHANGELOG entry? |
👍 |
Thanks for the example - can we find a way to test this in the local unit tests? We also still need a CHANGELOG entry. https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#changelog-entries |
I will try this in the next week. Regards. |
Still need an unit test? |
Yes - if we break this functionality there should be some local test which signals the problem. |
Closing as the dart-lang/io repository is merged into the dart-lang/tools monorepo. Please re-open this PR there! |
Re-opened at: |
Directory.listSync
only returnsLink
entries iffollowLinks: false
is passed.copyPath
needs afollowLinks
parameter to configure the call ofDirectory.listSync
and allow the copy ofLink
entries, as expected by lineelse if (file is Link) {