Correct grammar rule for <typeNotVoidNotFunction> to allow prefix
#3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix on `Function`
natebosch
approved these changes
Dec 4, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 5, 2023
This CL changes the specification grammar Dart.g such that it allows using `p.Function` to denote the built-in type `Function`. This is necessary in the case where 'dart:core' has been imported with an import prefix `p` (and it hasn't been imported without a prefix at the same time). The corresponding spec update is in dart-lang/language#3492. Change-Id: Iaaba1c3bc8f5d3a8700c8e62ec3a1af92334840b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339561 Reviewed-by: Chloe Stefantsova <[email protected]> Commit-Queue: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @modulovalue for reporting this grammar fault!
It is possible to import 'dart:core' with a prefix
p. This causes the built-in classFunctionto be denoted by the termp.Function(whereas the plain identifierFunctionis a lookup failure, or it denotes something else, or it actually works because we're also explicitly importing 'dart:core' without a prefix).In any case, we should allow
p.Functionin the grammar. This PR changes said grammar rule such that this is achieved.