[wildcard-variables] Fix typo in 'imports' example. #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
May 22, 2024
| @@ -181,7 +181,7 @@ main() { | |||
| ``` | |||
|
|
|||
| Import prefixes named `_` are non-binding and will provide access to the | |||
There was a problem hiding this comment.
I'd say "but" instead of "and" here. Maybe even "but will still"
The part after "and" is how non-_ prefixes work too, so erasing it should make no difference.
It's there for emphasis, saying that even though _ does not introduce a name for the imports, the extensions still work.
(But doesn't have to be this PR. Change looks good.)
lrhn
approved these changes
May 22, 2024
kallentu
approved these changes
May 22, 2024
|
Changed "and" -> "but" |
lrhn
pushed a commit
that referenced
this pull request
Jun 28, 2024
* [wildcard-variables] Fix typo in 'imports' example. * Improve extension name * Improve wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnamed (and private) extensions are non visible after the import. To make the example valid an extension should have a name